CJ Browser update #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proof of concept: using ev_text instead of text field.
Added accept header for collection+json media type.
| tf_passwd: EV_PASSWORD_FIELD | ||
| but: EV_BUTTON | ||
| table: HASH_TABLE [EV_TEXT_FIELD, STRING_32] | ||
| but_delete: detachable EV_BUTTON | ||
| table: HASH_TABLE [EV_TEXT_COMPONENT, STRING_32] |
There was a problem hiding this comment.
maybe we should use STRING_TABLE (not critical)
|
general comment, we should take the time to add comments and contract soon or later .. (sooner is better) |
jocelyn
added a commit
that referenced
this pull request
Apr 9, 2014
CJ Browser update Add delete support. Add missing Accept header. Setup a bigger timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add delete support.
Add missing Accept header.
Setup a bigget timeout.