Tor: Fix proxy bypass for stem version 1.8.0 #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stem release 1.8.0 moved to using `asyncio`, breaking our method of preventing the Tor control connection going through Tor itself. To fix this we introduce a new general proxy bypass mechanism that checks the list `network.bypass_proxy_filters`, calling each function in it. If any of the functions returns true, a normal socket instead of a proxied socket will be returned. The Tor controller provides such a filter that is installed by default and returns True when called from `stem.socket.ControlPort`.
|
This is insane in that it checks what is calling it in order to return different things! I love it! Nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stem release 1.8.0 moved to using
asyncio, breaking our method of preventing the Tor control connection going through Tor itself.To fix this we introduce a new general proxy bypass mechanism that checks the list
network.bypass_proxy_filters, calling each function in it. If any of the functions returns true, a normal socket instead of a proxied socket will be returned.The Tor controller provides such a filter that is installed by default and returns True when called from
stem.socket.ControlPort.