Upgrade to use Electron 12.0.12 #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #578
…ctron v12 WebPreferences.contextIsolation defaults to true… this means that window.require() will no longer function"
|
Something I noticed while testing: Electron 12 has a breaking change with the default value for |
|
@theolivenbaum if you look at the api script around creating browser windows. it forces nodeIntegration to true regardless of the setting in the c# code. Only the contextIsolation is pertinent here as towards breaking changes. |
|
(edited as I misread your comment) |
|
I have this issue as well. Waiting for the next release containing this fix. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the ElectronNET.CLI to use Electron v12.0.12 to prevent crashing when the auto update feature is used.
Resolves #578