Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs that prevent library compiling with the DEBUG macro set #81

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

benpeart
Copy link
Contributor

@benpeart benpeart commented Mar 1, 2024

Remove stale debug code that attempts to output the ProductID that is no longer being retrieved.

Update DEBUG_PRINT macros so that the code is always validated at compile time but is not called when DEBUG is undefined. This helps prevent stale debug code from accumulating when the debug version is not regularly compiled.

Fixes issue #80

…pile time but is not called when DEBUG is undefined. This helps prevent stale debug code from accumulating when the debug version is not regularly compiled.

Remove stake debug code that attempts to output the ProductID
that is no longer being retrieved.
Copy link
Member

@DeimosHall DeimosHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes works fine, except for one bug present in 9Axis cpp file

@DeimosHall DeimosHall merged commit 5e324c4 into ElectronicCats:master Mar 19, 2024
6 checks passed
@benpeart
Copy link
Contributor Author

@DeimosHall Did you already fix the issue in 9Axis.cpp before merging or do you need me to find/fix an issue and submit another pull request?

@DeimosHall
Copy link
Member

@benpeart don't worry, I already fixed it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants