Skip to content

mini V4 fixes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

mini V4 fixes #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c427208
fix phpdoc
QuentinGab Aug 14, 2025
7bed201
fix
QuentinGab Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Converters/MediaConverter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,11 @@ public function handle(): ?MediaConversion
return $this->convert($this->media, $parent, $copy, $storage, $temporaryDirectory);
});

if ($mediaConversion && $this->withChildren) {
if (
$mediaConversion &&
$mediaConversion->state === MediaConversionState::Succeeded &&
$this->withChildren
) {
$this->media->generateConversions(
parent: $mediaConversion,
filter: fn ($definition) => $definition->immediate,
Expand Down
4 changes: 2 additions & 2 deletions src/MediaConversionDefinition.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ class MediaConversionDefinition
{
/**
* @param (Closure(Media $media): MediaConverter) $converter
* @param bool $immediate Determine if the conversion should be dispatched immediatly and synchronously after the media is added
* @param MediaConversionDefinition[] $conversions
* @param null|bool|(Closure(Media $media, ?MediaConversion $parent): null|bool) $when
* @param null|(Closure(?MediaConversion $conversion, Media $media, ?MediaConversion $parent): void) $onCompleted
* @param MediaConversionDefinition[] $conversions
*/
public function __construct(
public string $name,
Expand Down