-
Notifications
You must be signed in to change notification settings - Fork 123
website issues #1151
Comments
I changed the text a bit. Can you modify the icon for "batteries included"? |
Which one should I take? (see http://fontawesome.io/icons/ for a list, you can search for battery too) The points where I don't write something, I'll change. Btw, can we change #1108 then?
The dropdown is sorted by the plugin status, i.e. best plugin at top. Of course it can be changed, but it seems dirty...
Are you talking about the 3 points on the bottom?
Tried with three test input-sets, but cannot reproduce. There is also no connection between the validation of the fields actually...
Have to see what I can do. The behavior of the HTML title-attribute is browser dependend, so I have no influence there. Only solution would be to switch to a tooltip plugin, but would be nice to avoid that...
Suggestions? Personally, I don't think it makes sense and that we should wait and see if it actually makes sense...
Good point, but minor. I'd like to fix this with implementing a button that does the same as for the conversion, but other things are more urgent.
Don't think I can fix that.
Something seems broken there, will have a look.
You go to the search, press "advanced options", select "filter by" and enter your name to search for. If you think we should have a button to this list in the profile, put it on the todo list. ^^
Tags do not allow spaces (that's the whole purpose of tags - a single word as description).
The structure.json is an array at the highest level, so merging it with news is not going to work. But I don't understand the problem, because the news.json is only generated, but never published on its own... it is put into the JS application.
Yes, you can use all HTML, but the place where the key will be used has to be marked with the |
Hi!
Which one should I take? (see http://fontawesome.io/icons/ for a list, you
can search for battery too) I think battery-three-quarters is good (shows
better that is is a bettery) or battery-full in case we want to show that
we are awesome. 👍
Yes, awesome (http://fontawesome.io/icon/battery-full/) is ok.
The points where I don't write something, I'll change. Btw, can we change
#1108 then?
The leftover there is changing the color theme for asciinema.
I renamed the issue.
> use some other plugin per default in snippet conversion (not dump), maybe
> line is best
The dropdown is sorted by the plugin status, i.e. best plugin at top. Of
course it can be changed, but it seems dirty...
Isn't it possible to preselect something which are not at top?
We could have some "top choices" and the rest is sorted by name, couldn't we?
> please add icons for the orientation, too
Are you talking about the 3 points on the bottom?
Yes, the word "orientation" is from the translation file.
> registration page: I enter first both passwords, then user, then mail,
> suddenly it says that second password is wrong
Tried with three test input-sets, but cannot reproduce. There is also no
connection between the validation of the fields actually...
Strange, I tried it twice with Firefox 45.5.0. So its a AngularJS bug?
> when creating snippets: clicking on "?" does not do anything (for hover
> you need patience, please show it immediately)
Have to see what I can do. The behavior of the HTML title-attribute is
browser dependend, so I have no influence there. Only solution would be to
switch to a tooltip plugin, but would be nice to avoid that...
When clicking would do something the hover behavior wouldn't be important.
> scope and organization should have defaults, description should not be
> enforced
Suggestions? Personally, I don't think it makes sense and that we should
wait and see if it actually makes sense...
I am afraid it is currently too tiresome to create snippets for the average
attention span people have. The feedback of others was really clear here.
> when submitting errornous snippet, it says github button below should be
> pressed, but there is no such button
Good point, but minor. I'd like to fix this with implementing a button that
does the same as for the conversion, but other things are more urgent.
The list is not ordered by urgency or priority.
#1033 are still the high priority issues
> how to list all snippets I have created?
You go to the search, press "advanced options", select "filter by" and enter
your name to search for. If you think we should have a button to this list
in the profile, put it on the todo list. ^^
Yes, we really should have! Its on the todo list.
> space separated tags get automatically merged to a single tag? What is the
> rationale here?
Tags do not allow spaces (that's the whole purpose of tags - a single word
as description).
So how does the interface work? Do I have to click to add multiple tags?
> Do we really need the news.json? Can't it be a part of structure.in?
The structure.json is an array at the highest level, so merging it with news
is not going to work. But I don't understand the problem, because the
news.json is only generated, but never published on its own... it is put
into the JS application.
Then the issue is that the file was added to the repo?
[...]
is not good. `ui-sref` operates on the state name by the way, not on links.
I suppose its AngularJS 101, but can you add it to the docu?
best regards
|
Can't tell. But as normal people do not work against the flow of forms, its not worth to investigate in my opinion.
I can't force the title to show earlier, only a move towards a tooltip plugin would help.
You write something, press enter, write something, press enter... yes, it is also counter-intuitive for me, as enter often forces the form to submit, but that's how the plugin works unfortunately.
Was it? If so, yes, it is. |
Ok, its low-priority anyway.
Ok, lets keep the issue for later then if miscategorization really happens.
It still is? |
Just realized now that I omitted them intentionally. It looks crowded with so many icons and it is also very hard to find fitting ones for these points. A simple arrow (enumeration sign basically) is no problem, but I still think it looks crowded. |
Yes, it looks a bit crowded but reducing icons seems not to be the best way to deal with it. Anyway: the button has the same number of columns as above, so it should work the same way? And I am sure you can find some nice icons ;) Btw. do you have some ideas how we can bring icons into the the tutorials and NEWS entries to make them look nicer? |
In the text or where exactly? |
Yes, next to the text (e.g. on the left side). For example "Get It!" and "Stay tuned!" would look much nicer. Hopefully you will find other opportunities while writing the release notes for the homepage! |
I doubt we can do that easily... |
Ok, it is a minor thing, let us keep it in the backlog. |
The issue is clearly with the XML plugin. When I use absolute keys in the xml file (the ones that the snippet will have when it gets stored), everything works fine. The import with relative paths does also not work with I think I read somewhere something about compile-time configuration for the xml plugin with relative keys. Either we use such an option for the website or we omit the plugin entirely... doesn't make sense to work with absolute paths.
This is another issue that I'll fix right away. |
Thanks, I opened #1159 for the XML relative paths issue. Seems like this ticket is nearly finished. Do you think it is useful now to let more people test the snippet service? I would prefer if the snippet service already runs on the new server for further tests. |
I was actually wrong about this point, you can also use It actually works that good that the router will give you a 404 page, even if you request something like the feed.rss file. That's why you have to add
Yes, I think so, but I first want to make sure the jenkins build script works with what I installed so far. We also need a service setup for the backend as it might crash. |
Yes, that are very good news! Please update the README.
Please also explain (in the README) what "something like" is. For which links is
Yes, let us discuss these issues in #1161 please. |
Meant are non-internal links, even if they target resources on the same server. If a link is external, it obviously is routed as such. But if a link is relative or has the same base URL as the frontend as target, it would get routed internally (by the JS app, not by the browser) without
|
Where should we link them to? |
Global configuration database: without link |
I added one or two more links than in your suggestions, see 8e7b649. |
Thank you! Looks great with links now! There are quite some 404 now, however, e.g. storage plugins. And it would also be nice if the logo+title would be a link, too? |
Doesn't look good with the logo/title being a link, I tried it. That's also why I tweaked some of the suggestions a little bit. 404 are interesting, I tried all links locally. Must investigate that further... |
How can I find out? At least for me it matters a lot: I always need to check manually if the rest-client is running. And I think it generally of interest if retrying with different data might lead to success.
It would be enough if we have it at the "public places" (login, snippet transformation).
Seems like there is commercial interest behind this. Btw. what are the results of API testing and benchmarking? Did you try something? |
I tried some testing with dredd, but forget about it, doesn't work. I'm actually not even sure what it does, but what I know for sure is that it will never be able to test our authentication stuff, so it is worthless. Didn't benchmark anything though. |
Would be good if you take a look. Maybe the frontend has more user-visible optimization potential. In particular I noticed that many files are not downloaded before the whole application.js is downloaded. Is there some way to prefetch things? |
Can you take a look at http://grinder.sourceforge.net/ ? |
I added some further usability issues:
|
Thanks, I updated the issues that I noticed in #1221 |
About the black screen, maybe it is fixed when it is CSS valid: |
Any error in the browser console?
All errors are vendor issues from fontawesome, bootstrap, etc. I highly doubt they are really invalid css. And even if, I can't change them as they are packed automatically. As the error appeared with the move to selfhosting of asciinema, I guess the problem is related to this. It doesn't occur in firefox 45.4.0 and also not in firefox 45.6.0 btw.
My best guess is: crash |
I think we should remove the view counter from the snippets. It spams the repository with a commit each time someone looks at a snippet and I guess it would also speed up everything if it wasn't there. |
The problem is caused by the privacy badger. Maybe we should report the problem there?
How to fix this?
You could simply not do Btw. can you restore my snippets? They were modified variants of some files, its not so easy to modify them again. Please also upload more snippets, its not so inviting to contribute if there are so few snippets. |
No idea, it's your decision if you are using it. But the chances they will tell you that you are blocking scripts and stuff and that it is normal behavior is quite high.
Well, I expect it to be fixed already. I'm quite sure it had to do with the high loads / sort of endless loops caused by wrong config for the simpleini plugin.
I thought about this too, but what do we gain from the views? I think nothing... it was collect-only until now anyway. And we don't need the info in the snippet exports, so I removed it.
I can try to. |
Okay, let us reintroduce it when we actually need it for sorting or similar.
Thank you! One more question: I do not understand the "Action" button in the search interface. Why not simply make the whole lines links? The problem I have with the button is that I cannot press with the middle mouse on it (to open it in a background tab) |
The button is not a link, there is the issue. It is routed by the internal router and this one actually cannot be changed because quite some data is moved between the states (more than the key which is visible in the URL). |
I reported the issue about Privacy Badger: EFForg/privacybadger#1103 |
Ok forget about it, we have to remove the git script, it deletes data / prevents saving of data. I could also not restore some of the snippets you imported with the list plugin. |
What do you mean? It is quite unlikely that two people upload/edit snippets at the same time. For all other cases you should avoid doing
I did not import something with the list plugin. Do you mean line plugin? What is the issue? You also find older versions of these config files in http://markus-raab.org/Info/Config (you can upload all of them). Btw. if someone has js disabled: You can argue that it is safe to activate js, because all of the js we use is free software and can be inspected in our repo (including how it is build). And if someone does not want to disable js: you can argue that all information is on github too (but less nice presented and without snippets functionality...). |
Are you sure that it is executed in the background? E.g. I uploaded another snippet, for me it works really nicely now! The script, however, was not in the repo afterwards? |
Sorry, ofc I meant the line plugin. |
Do you mean it removed other snippets or that it prevented something from being committed? Btw. we could also log into the snippet repo, that might be useful. |
Ok, maybe something else is broken. It again removed meta data of several snippets with a restart of the backend. 😭 |
Dont worry, we will find the issue. Btw. finish the thesis first ;) |
🤦♂️
and the subkeys (aka snippet) can contain the root key (aka |
Btw. it seems that some augeas lenses can indeed import stuff, but cannot export the same stuff again (e.g. tried it with the apache2 configuration and the Httpd lens). So I think this lenses are of no value for us and we should disable them to improve performance. What do you think? Btw. I already tried on my dev VM if this behavior changes if I add the root key of the snippets to the keyset that is used during export, but it didn't change anything.
(neither export with 2-5, nor with 1-5 works) |
For me hosts works really nicely: https://www.libelektra.org/entries/details/augeas~2Fhosts~2Fv1~2Flocalhost and I think it is really informative what the differences of abstractions between augeas and otherwise written parsers can be. But yes those who definitely do not work, please disable them. But please report it to #1215 (so that @fberlakovich knows the issues) or, for non-augeas plugins to a separate issue. We have to investigate where the problem is and always should try to keep all plugins running on the website. |
Yes, hosts works fine, but some others unfortunately not. I'll start a list of plugins + checks which we can then use to file a new issue. |
Thank you for all the fixes! I will close this issue (consider it as fixed) #1228 are new ideas how we could continue and the leftovers from here. |
Frontend
Questions
Archive
Frontend
href
in readmeBackend
Other
Questions
ui-sref
for links?The text was updated successfully, but these errors were encountered: