Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Table #363

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Improve Table #363

merged 1 commit into from
Oct 19, 2016

Conversation

furybean
Copy link
Contributor

@furybean furybean commented Oct 12, 2016

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's Contributing Guide.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.
  1. Add TableStore & TableLayout.
  2. Remove customCriteria & customCriteria.
  3. Remove fixedColumnCount.
  4. Add fixed prop for TableColumn.
  5. Add selectable prop for TableColumn[type="selection"].
    Element el-form-item uses attribute name prop while el-table uses property #293 table 组件有滚动条时,表头列没对齐 #264 table组件如何固定左边某列和右边某列 #60 建议 Table 组件增加筛选、后端排序的功能 #180 router 切换路由 table组件 body内的宽度 变化的问题 #258

@acelan86
Copy link

acelan86 commented Oct 14, 2016

table数据更新后没有更新高度
一开始表格为[], body高度为0, 然后异步请求数据后设置tableDate,高度不会被更新,其实内容是存在且更新的

更新,找到原因,设置bodyWrapper.style.height = 0后,在怎么更新获取的this.table.$el的高度永远都是表头的高度,所以需要再斟酌下写法

bug2: 左侧固定的列高度重新计算了,右侧固定的列高度没有重新计算

@perfectyang
Copy link

@furybean 你这个pr,怎么还不给merge 过去呢

@furybean
Copy link
Contributor Author

@perfectyang 还稍微有点问题,我晚上修改下后就 merge。

@perfectyang
Copy link

@furybean 等你,等你,等你,重要的事说三遍,哈哈

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 39.197% when pulling 5428e74 on furybean:master into 815bdd4 on ElemeFE:master.

@@ -305,33 +324,52 @@

可将表格内容 highlight 显示,方便区分「成功、信息、警告、危险」等内容。

:::demo 为行添加自定义背景色,表明该行处于某种状态。若某一行拥有`custom-criteria`数组中的某个字段且值为`true`,则为该行添加`custom-background-colors`数组中对应的背景色
:::demo 可以通过指定 Table 组件的 rowClassName 属性来为 Table 中的某一行添加 class,表明该行处于某种状态。。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

两个句号

| align | 对齐方式 | String | left, center, right | left |
| selectable | 仅对 type=selection 的列有效,类型为 Function,Function 的返回值用来决定这一行的 CheckBox 是否可以勾选 e | Function | - |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多了个 e

1. Add TableStore & TableLayout.
2. Remove customCriteria & customBackgroundColors.
3. Remove fixedColumnCount.
4. Add fixed prop for TableColumn.
5. Add selectable prop for TableColumn[type="selection"].
@furybean
Copy link
Contributor Author

@QingWei-Li @Leopoldthecoder Done

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 39.197% when pulling 68e04ee on furybean:master into 815bdd4 on ElemeFE:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants