Skip to content

Conversation

voodoo144
Copy link

Now POST to /session doesn't redirect to /session/:sessionId url, it now return sessionId value in json response.

@voodoo144
Copy link
Author

@@ -56,8 +56,8 @@ public function session($browser = 'firefox',
'/session',
array('desiredCapabilities' => $desired_capabilities),
$curl_opts);

  • // var_dump($results);
  • return new PHPWebDriver_WebDriverSession($results['info']['url']);
  •  //var_dump($results);
    
  • return new PHPWebDriver_WebDriverSession($results['info']['url'].$results['sessionId']);

I test this code with GhostDriver 1.0.4, when I write it Selenium 2.34 was still unreleased.

@jvanbouchaute
Copy link

+1. Breaks compatibility with Selenium 2.35

@adamgoucher
Copy link
Member

I'll look at this tonight

@jvanbouchaute
Copy link

Thanks !
Op 20-aug.-2013 12:29 schreef "adam goucher" notifications@github.com het
volgende:

I'll look at this tonight


Reply to this email directly or view it on GitHubhttps://github.com//pull/44#issuecomment-22935523
.

@voodoo144
Copy link
Author

thanks a lot )

@adamgoucher adamgoucher merged commit 8d26aec into Element-34:master Aug 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants