That time Pieter Wuille tested us all and we failed him #2061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from upstream: sipa/bech32@2b0aac6 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… onchain addr." This reverts commit 6af8f29. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
niftynei
reviewed
Oct 31, 2018
|
|
||
| hrp = tal_arr(tmpctx, char, strlen(str)); | ||
| data = tal_arr(tmpctx, u5, strlen(str)); | ||
| hrp = tal_arr(tmpctx, char, strlen(str) - 6); |
There was a problem hiding this comment.
i realize this is a revert, so maybe this is already taken care of, but if not can you add some context about why these offsets are necessary, maybe as a code comment?
There was a problem hiding this comment.
It's actually documented in the bech32 reference code header to have these requirements.
The reason: bech32 includes a 30-bit (6char) checksum, and a 1 between hrp and data, meaning hrp must be 7 chars shorter. Plus one for NUL terminator, so -6.
The data is not NUL-terminated, and the code insists that hrp be at least one letter long, so that's -8.
But you made me re-read the code and write some test cases to be sure!
|
ACK 7e73ea7 |
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2063 as a side-effect.