Gossip cleanups #3044
Merged
Gossip cleanups #3044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We overrode this with travis, but it's not a travis issue. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
niftynei
approved these changes
Sep 11, 2019
| @@ -711,7 +711,7 @@ bool gossip_store_load(struct routing_state *rstate, struct gossip_store *gs) | |||
| goto corrupt; | |||
|
|
|||
| /* If last timestamp is within 24 hours, say we're OK. */ | |||
| contents_ok = (last_timestamp >= time_now().ts.tv_sec - 24*3600); | |||
| contents_ok = (last_timestamp >= gossip_time_now(rstate).ts.tv_sec - 24*3600); | |||
There was a problem hiding this comment.
does this belong with c5ab892?
common/utils.h
Outdated
| * | ||
| * Usefully, you can refer to DEVELOPER-only fields here. */ | ||
| #if DEVELOPER | ||
| /* Makes ure that nondev is evaluated, and valid */ |
| * for the entire stream. | ||
| */ | ||
| unsigned long compressed_len = tal_bytelen(data) | ||
| + 6 + 5*(tal_bytelen(data) + 16384)/16384; |
|
ack e5b5d2b |
We've been slack, but it's going to be important for testing ratelimiting. And it currently has a minor memory leak. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
In particular, the timestamp might be wrong once we start checking that. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
There are some more #if DEVELOPER one-liners coming, this makes them clear, but still lets them stand out. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
For memory-usage reasons, struct chan doesn't use a tal destructor, in favor of us calling free_chan in the right places. In DEVELOPER mode, we should check that is the case. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
In particular, it does zlib. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
gossip-cleanups
branch
from
719bac7 to
9989154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various gossip-related cleanups I had lying around and which I needed for my next patches.