Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let invoice command specify exact channel(s) to share. #3351

Merged

Conversation

@rustyrussell
Copy link
Contributor

rustyrussell commented Dec 17, 2019

I left the name as 'exposeprivatechannels' even though it's a bit of a misnomer. 'exposure' would be my preferred change if we change it, since it doesn't imply too much about the semantics (which are kinda complex).

Added by ZmnSCPxj:

Fixes: #3198

This lets us do more flexible filtering in the next patch.  But it also
keeps some weird logic out of gossipd.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Changed: JSON API: `invoice` `exposeprivatechannels` can specify exact channel candidates.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell added this to the 0.8.1 milestone Dec 17, 2019
@rustyrussell rustyrussell requested a review from cdecker as a code owner Dec 17, 2019
Copy link
Collaborator

darosior left a comment

ACK a436922

This fixes #3198 too.

@ZmnSCPxj ZmnSCPxj merged commit c74fceb into ElementsProject:master Jan 4, 2020
4 checks passed
4 checks passed
bitcoin-bot/acks Acks by darosior
bitcoin-bot/changelog This PR has at least one changelog entry
bitcoin-bot/fixups PR does not contain unsquashed fixups
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.