Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

funding: enable push_msat #3369

Merged
merged 1 commit into from Dec 24, 2019
Merged

Conversation

@niftynei
Copy link
Collaborator

niftynei commented Dec 21, 2019

it's that time of year (merry xmas!) 馃巺 馃ざ

enables the ability to push_msat on fundchannel (and fundchannel_start)

@niftynei niftynei added the funding label Dec 21, 2019
@niftynei niftynei added this to the 0.8.1 milestone Dec 21, 2019
@niftynei niftynei requested a review from cdecker as a code owner Dec 21, 2019
@rustyrussell

This comment has been minimized.

Copy link
Contributor

rustyrussell commented Dec 22, 2019

Ack 8919d98

it's that time of year (merry xmas!)

enables the ability to push_msat on fundchannel

Changelog-Added: RPC: `fundchannel` and `fundchannel_start` can now accept an optional parameter, `push_msat`, which will gift that amount of satoshis to the peer at channel open.
@niftynei niftynei force-pushed the niftynei:nifty/push_msat branch from 8919d98 to 6eaee6c Dec 23, 2019
@niftynei

This comment has been minimized.

Copy link
Collaborator Author

niftynei commented Dec 24, 2019

re-applying ACK, added a Changelog line and fixed the documentation

ACK 6eaee6c

@niftynei niftynei merged commit 689dd28 into ElementsProject:master Dec 24, 2019
4 checks passed
4 checks passed
bitcoin-bot/acks Acks by niftynei
bitcoin-bot/changelog This PR has at least one changelog entry
bitcoin-bot/fixups PR does not contain unsquashed fixups
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.