Initial PSBT support #3738
Merged
Initial PSBT support #3738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/psbt-support
branch
from
bbf9724 to
2ea4826
Compare
Collaborator
Author
|
depends on ElementsProject/libwally-core#190 to pass VALGRIND tests |
Includes an important PSBT fix (ElementsProject/libwally-core#190) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
add the missing psbt helpers for adding and removing an input and output
we can now keep associated witness data with the output in the psbt struct, so we do that.
Make sure that we permute them also! Fixes weird spacing also
Pass scriptSig + witness info down to the PSBT struct
Move all psbt creation into single method, new_psbt note that if a psbt is init'd for a transaction that's deserialized with scripts etc already attached, then set_global_tx will fail. instead, we empty all of this out first. if the tx is being re-init'd from a tx source that had a psbt attached (e.g. fromwire_) then the script/witness data will get populated appropriatel from there.
rustyrussell
force-pushed
the
nifty/psbt-support
branch
from
2ea4826 to
27dfdca
Compare
now that witness script data is saved into the tx/psbt which is serialized across the wire, there's no reason to use witscript to do this. good bye witscript!
Changelog-Added: JSON-API: `txprepare` returns a psbt version of the created transaction
rustyrussell
force-pushed
the
nifty/psbt-support
branch
from
27dfdca to
83d13f2
Compare
Contributor
|
Rebased and added latest Wally version. Ack 83d13f2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at including PSBT structs into the transaction mechanics. We now can carry witness scripts around in the psbt instead of serializing them separately as
witscripts, so we strip thewitscriptsupport.Finally, as a showpiece, we return the PBST version of the transaction from
txprepare.