renepay: test channel capacity unavailable #7307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagrang3
force-pushed
the
renepay_test_capacity_unavailable
branch
from
f9a9eb3
to
4f71c76
Compare
Closed
plugins/renepay/routetracker.c
Outdated
| // plugin_log(pay_plugin->plugin, LOG_DBG, "tracking %zu routes", | ||
| // route_map_count(pay_plugin->route_map)); | ||
| // plugin_log(pay_plugin->plugin, LOG_DBG, "%s", | ||
| // fmt_route_map(tmpctx, pay_plugin->route_map)); |
There was a problem hiding this comment.
Extra commented code here and below
|
Looks good apart from unused code in the second commit. |
Add a test that checks `get_route` and `uncertainty_update` behaviour's handling of missing channel capacities. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Keep a double-entry record of pending routes so that we can flag them as not memory leaks. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Delete temporary gossmap files after unit tests completion. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
endothermicdev
force-pushed
the
renepay_test_capacity_unavailable
branch
from
371c6bc
to
879320f
Compare
|
Rebased on the updated mocks and removed the unused debugging. |
|
ACK 879320f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test that checks
get_routeanduncertainty_updatebehavior's handling of missing channel capacities.As pointed out in PR #7194: renepay couldn't handle a failed call to
gossmap_chan_get_capacityleading toin rare cases.
After #7125 this issue was fixed, this PR adds a unit test to confirm that.
Therefore #7194 can be closed.