offers: fix crash when receiving response to offer without offer_issuser_id
#7525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
ACK 9de4619
Guessing that it need just a rebase on master?
FAILED tests/test_pay.py::test_offer_experimental_fields - AssertionError: Regex pattern did not match.
Regex: 'Unknown offer'
Input: "RPC call failed: method: fetchinvoice, payload: ('lno1qgsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzrcgqypq59r5v4ehghm0venx2ujlwpshg6zlwdjkceskyypxdeze35wncs2l2u4gfzyrpds00e6yakfrt6ctrw5n9qanzhqr2x878wdv5qgpqq',), error: {'code': 1005, 'message': 'Timeout waiting for response'}"
…uer_id` Now we actually check the other fields too, as per BOLT! Reported-by: https://github.com/hMsats Fixes: ElementsProject#7513 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
ShahanaFarooqui
force-pushed
the
offer-crash-fix
branch
from
9de4619 to
3007dfc
Compare
niftynei
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we actually check the other fields too, as per BOLT!
Reported-by: https://github.com/hMsats
Fixes: #7513