Anchor code cleanup: always use anchors, but only boost to estimateblockfee 12. #7832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/anchors-clarity
branch
6 times, most recently
from
ccfe46a to
c4a40ab
Compare
rustyrussell
force-pushed
the
guilt/anchors-clarity
branch
2 times, most recently
from
70c7655 to
2bef5af
Compare
This lets us maintain a reasonable 2 week target for commitment tx. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1. merge_deadlines can't really fail. 2. We don't care about incoming HTLCs with no preimage. 3. Debug print anchor points as soon as we calc them. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We're going to call this twice. But this patch also takes care that a failed attempt to create an anchor doesn't alter other variables! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: Protocol: we now create a low-priority (2016 down to 12 blocks fee target) anchor for low-fee unilateral closes even if there's no urgency.
…chors. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/anchors-clarity
branch
from
f3ade21 to
f8db7fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a commitment tx isnt' urgent (no HTLCs) we didn't create an anchor at all. This is problematic as the user doesn't have a good way to do it themselves.