Unilateral lease close fixes #8111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se time. What we expect to happen: 1. l3, which unilaterally closed, waits 4032 blocks (minus those mined) before trying to send get its "to_local" funds back. 2. This should then succeed. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…too early (leases). current height + to_self_delay[LOCAL] is correct normally, but if we have an outstanding lease it's longer. Not a big issue, because lightningd will retry until its spendable, but wrong. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
If the nSequence in the tx it produces is not at least the value we test in the script, the tx will always fail: ``` error code: -26\nerror message:\nmandatory-script-verify-flag-failed (Locktime requirement not satisfied) ``` If we have a lease, the nSequence is max(lease-time-remaining, to-self-delay), so have onchaind tell lightningd the correct nSequence. Fixes: ElementsProject#7460 Reported-by: https://github.com/pabpas Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-EXPERIMENTAL: Correctly collect our own (delayed) funds if we have a unilateral close when we are still offering a lease.
rustyrussell
added
Type::Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got the nSequence wrong if there's a lease in progress. Increase test coverage, and then make the two fixes where we used the "to-self-delay" (which is correct for the non-lease case).
Fixes: #7460