-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate bash scripts to node #11
Conversation
Found this project via Hacker News today - very neat! I have a windows PC and thought I might help by testing this. I cloned this repo and ran SuccessessThe following test (entered in Powershell/VS Code Terminal) ran successfully (though I hadn't completed the assignment first):
FailuresThe following commands failed, with the ensuing errors in the terminal:
|
Thanks for the test! I'm actually not quite done 😅. |
Addresses #10 (add windows support)
We're using an experimental vitest API now. I don't see a need to upgrade vitest for now, but it might be important for future updates.
I don't have a windows PC to test, so this would only work in theory. I should also note that I'm still using bash syntax for the
solve.mjs
file where we call out to the shell to usepatch
. We might be able to migrate to an npm package (I'd rather not), but I'll try to investigate alternatives before merging.