Skip to content

Conversation

swar30
Copy link

@swar30 swar30 commented Jan 15, 2017

implementation for #434

@coveralls
Copy link

coveralls commented Jan 15, 2017

Coverage Status

Coverage decreased (-0.08%) to 99.925% when pulling aa78e48 on swar30:issue-434/support-$window-in-timeout-service into 818aedb on Gillespie59:development.

@swar30
Copy link
Author

swar30 commented Jan 15, 2017

Checking reduced coverage

@coveralls
Copy link

coveralls commented Jan 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 564b060 on swar30:issue-434/support-$window-in-timeout-service into 818aedb on Gillespie59:development.

@swar30
Copy link
Author

swar30 commented Jan 15, 2017

BTW, I'm rather new to writing eslint rules, so would appreciate detailed code review

@swar30
Copy link
Author

swar30 commented Jan 15, 2017

May have found an issue with implementation when running on my own code base, investigating

@coveralls
Copy link

coveralls commented Jan 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 39d7da7 on swar30:issue-434/support-$window-in-timeout-service into 818aedb on Gillespie59:development.

@coveralls
Copy link

coveralls commented Jan 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling f4c34dd on swar30:issue-434/support-$window-in-timeout-service into 818aedb on Gillespie59:development.

@swar30
Copy link
Author

swar30 commented Jan 15, 2017

Fixed issues, ready for review


# timeout-service - use `$timeout` instead of `setTimeout`


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have this extra empty lines ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on windows, I think it's CRLF issue, will try to fix

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gillespie59 fixed the extra lines issue

@coveralls
Copy link

coveralls commented Jan 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling f1106da on swar30:issue-434/support-$window-in-timeout-service into 818aedb on Gillespie59:development.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f1106da on swar30:issue-434/support-$window-in-timeout-service into 818aedb on Gillespie59:development.

@EmmanuelDemey EmmanuelDemey merged commit 3b8152a into EmmanuelDemey:development Jan 15, 2017
@swar30
Copy link
Author

swar30 commented Jan 15, 2017

@Gillespie59 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants