-
Notifications
You must be signed in to change notification settings - Fork 129
issue 434 - $window support in timeout-service #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue 434 - $window support in timeout-service #435
Conversation
Checking reduced coverage |
BTW, I'm rather new to writing eslint rules, so would appreciate detailed code review |
May have found an issue with implementation when running on my own code base, investigating |
Fixed issues, ready for review |
docs/timeout-service.md
Outdated
|
||
# timeout-service - use `$timeout` instead of `setTimeout` | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you have this extra empty lines ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on windows, I think it's CRLF issue, will try to fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gillespie59 fixed the extra lines issue
1 similar comment
@Gillespie59 thanks |
implementation for #434