Skip to content

1.6.4 #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2017
Merged

1.6.4 #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d33cde
Issue #442 DI validation error for a function without parameters
EmmanuelDemey Mar 19, 2017
64fabf0
Update to 1.6.4
EmmanuelDemey Mar 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-plugin-angular",
"version": "1.6.3",
"version": "1.6.4",
"description": "ESLint rules for AngularJS projects",
"main": "index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion rules/di.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ module.exports = {
return;
}
}
} else {
} else if (fn.params.length > 0) {
report(fn);
}
} else if (fn.params && fn.params.length !== 0) {
Expand Down
3 changes: 3 additions & 0 deletions test/di.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ angularObjectList.forEach(function(object) {
}, {
code: 'angular.module("myModule").' + object + '(myFunction);function MyFunction() {}',
options: ['function']
}, {
code: 'angular.module("myModule").' + object + '(myFunction);function myFunction() {}',
options: ['$inject']
}, {
code: 'angular.module("myModule").' + object + '(myFunction);myFunction.$inject=[];function myFunction() {}',
options: ['$inject']
Expand Down