Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-fix/205 fix job wizard #245

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions Migrations/202211221230_alter_companies_url_logoUrl_as_nullable.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
using Domain.Framework.Constants;
using FluentMigrator;

namespace Migrations
{
[Migration(202211221230)]
public class _202211221230_alter_companies_url_logoUrl_as_nullable : Migration
{
public override void Up()
{
Alter.Table(TableConstants.Companies)
.AlterColumn("Url")
.AsString()
.Nullable();

Alter.Table(TableConstants.Companies)
.AlterColumn("LogoUrl")
.AsString()
.Nullable();
}

public override void Down()
{
Alter.Table(TableConstants.Companies)
.AlterColumn("Url")
.AsString()
.NotNullable();

Alter.Table(TableConstants.Companies)
.AlterColumn("LogoUrl")
.AsString()
.NotNullable();
}
}
}
31 changes: 31 additions & 0 deletions Web/Framework/Attributes/RequiredIfTrueAttribute.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
using System;
using System.ComponentModel.DataAnnotations;

namespace Web.Framework.Attributes
{
[AttributeUsage(AttributeTargets.Property)]
public class RequiredIfTrueAttribute : RequiredAttribute
{
private string PropertyName { get; }

public RequiredIfTrueAttribute(string propertyName)
{
PropertyName = propertyName;
}

protected override ValidationResult IsValid(object value, ValidationContext context)
{
object instance = context.ObjectInstance;
Type type = instance.GetType();

bool.TryParse(type.GetProperty(PropertyName).GetValue(instance)?.ToString(), out bool propertyValue);

if (propertyValue && string.IsNullOrWhiteSpace(value?.ToString()))
{
return new ValidationResult(ErrorMessage);
}

return ValidationResult.Success;
}
}
}
14 changes: 7 additions & 7 deletions Web/ViewModels/CompanyViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,20 @@ public class CompanyViewModel
{
public int Id { get; set; }

[Required(ErrorMessage = "El nombre de la empresa es requerido."), StringLength(50)]
[Display(Name = "Nombre de la empresa")]
[Required]
public string Name { get; set; }

[StringLength(int.MaxValue), Url(ErrorMessage = "La dirección Web de la compañía debe ser un Url válido.")]
[Display(Name = "Sitio Web (opcional)")]
public string Url { get; set; }

[Display(Name = "Correo electrónico"),]
[Required(ErrorMessage = "El campo correo electrónico es requerido"), StringLength(int.MaxValue), EmailAddress(ErrorMessage = "Correo electrónico inválido.")]
[DataType(DataType.EmailAddress)]
public string Email { get; set; }

[StringLength(int.MaxValue), Url(ErrorMessage = "El logo de la compañía debe ser un Url válido.")]
[Display(Name = "Sitio Web (opcional)")]
[StringLength(int.MaxValue), Url(ErrorMessage = "La dirección Web de la compañía debe ser un Url válido.")]
public string Url { get; set; }

[Display(Name = "Logo de la empresa (.jpg, .png) (opcional)")]
[StringLength(int.MaxValue), Url(ErrorMessage = "El logo de la compañía debe ser un Url válido.")]
public string LogoUrl { get; set; }

public int? UserId { get; set; }
Expand Down
74 changes: 38 additions & 36 deletions Web/ViewModels/WizardViewModel.cs
Original file line number Diff line number Diff line change
@@ -1,60 +1,39 @@
using System;
using Domain.Entities;
using System.Collections.Generic;
using System.ComponentModel.DataAnnotations;
using Domain;
using Domain.Entities;
using Web.Framework.Attributes;

namespace Web.ViewModels
{
public class WizardViewModel: BaseViewModel
public class WizardViewModel : BaseViewModel
{
public int? Id { get; set; }

[Display(Name = "Localidad")]
public string LocationName { get; set; }
public string LocationLatitude { get; set; }
public string LocationLongitude { get; set; }
[Required(ErrorMessage = "Debes seleccionar una localidad válida")]
public string LocationPlaceId { get; set; }


public bool CreateNewCompany { get; set; } = true;

[Display(Name = "Compañía")]
public int? CompanyId { get; set; }

[Required(ErrorMessage = "El campo título es requerido."), StringLength(int.MaxValue)]
[Display(Name = "Título. ¿Qué estás buscando?")]
public string Title { get; set; }


[Required(ErrorMessage = "Debes especificar al menos un requisito."), StringLength(int.MaxValue)]
[Display(Name = "Requisitos para aplicar")]
public string Description { get; set; }

[Required(ErrorMessage = "El campo como aplicar es requerido"), StringLength(int.MaxValue)]
[Display(Name = "¿Cómo Aplicar?")]
public string HowToApply { get; set; }

//[Required(ErrorMessage = "El nombre de la empresa es requerido."), StringLength(50)]
[RequiredIfTrue(nameof(CreateNewCompany), ErrorMessage = "El nombre de la empresa es requerido."), StringLength(50)]
[Display(Name = "Nombre de la empresa")]
public string CompanyName { get; set; }

[StringLength(int.MaxValue), Url(ErrorMessage = "La dirección Web de la compañía debe ser un Url válido.")]
[Display(Name = "Sitio Web (opcional)")]
public string CompanyUrl { get; set; }

//[Required(ErrorMessage = "El campo correo electrónico es requerido"), StringLength(int.MaxValue), EmailAddress(ErrorMessage = "Correo electrónico inválido.")]
[Display(Name = "Correo electrónico"),]
[RequiredIfTrue(nameof(CreateNewCompany), ErrorMessage = "El campo correo electrónico es requerido"), StringLength(int.MaxValue), EmailAddress(ErrorMessage = "Correo electrónico inválido.")]
[Display(Name = "Correo electrónico")]
[DataType(DataType.EmailAddress)]
public string CompanyEmail { get; set; }

[Display(Name = "Sitio Web (opcional)")]
[StringLength(int.MaxValue), Url(ErrorMessage = "La dirección Web de la compañía debe ser un Url válido.")]
public string CompanyUrl { get; set; }

[StringLength(int.MaxValue), Url(ErrorMessage = "El logo de la compañía debe ser un Url válido.")]
[Display(Name = "Logo de la empresa (.jpg, .png) (opcional)")]
[StringLength(int.MaxValue), Url(ErrorMessage = "El logo de la compañía debe ser un Url válido.")]
public string CompanyLogoUrl { get; set; }

[Display(Name = "¿Es un puesto remoto?")]
public bool IsRemote { get; set; }
[Required(ErrorMessage = "El campo título es requerido."), StringLength(int.MaxValue)]
[Display(Name = "Título. ¿Qué estás buscando?")]
public string Title { get; set; }

[Required(ErrorMessage = "Debes elegir una categoría.")]
[Display(Name = "Categoría")]
Expand All @@ -64,8 +43,31 @@ public class WizardViewModel: BaseViewModel
[Display(Name = "Tipo de jornada")]
public int JobTypeId { get; set; }

[Display(Name = "¿Es un puesto remoto?")]
public bool IsRemote { get; set; }

[Display(Name = "Localidad")]
[Required(ErrorMessage = "Debes seleccionar una localidad válida")]
public string LocationName { get; set; }

public string LocationLatitude { get; set; }

public string LocationLongitude { get; set; }

public string LocationPlaceId { get; set; }

[Required(ErrorMessage = "Debes especificar al menos un requisito."), StringLength(int.MaxValue)]
[Display(Name = "Requisitos para aplicar")]
public string Description { get; set; }

[Required(ErrorMessage = "El campo como aplicar es requerido"), StringLength(int.MaxValue)]
[Display(Name = "¿Cómo Aplicar?")]
public string HowToApply { get; set; }

public IEnumerable<Category> Categories { get; set; } = new List<Category>();

public IEnumerable<HireType> JobTypes { get; set; } = new List<HireType>();

public List<Company> Companies { get; internal set; }
}
}
}
5 changes: 5 additions & 0 deletions Web/Views/Jobs/Details.cshtml
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
@model JobDetailsViewModel
@using Microsoft.AspNetCore.Html
@inject IUrlHelper urlHelper;

@section Styles {
<link href="~/css/jobs/details.css" rel="stylesheet">
}

<section class="page-title-banner" style="background-color:rgb(20, 177, 187)">
<div class="container">
<div class="row m-0 align-items-end detail-swap">
Expand Down
Loading