Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undebate-ssp send password#154 #8

Merged
merged 19 commits into from
Oct 21, 2022

Conversation

ice1080
Copy link
Contributor

@ice1080 ice1080 commented Oct 20, 2022

No description provided.

@ice1080 ice1080 mentioned this pull request Oct 20, 2022
3 tasks
@ddfridley
Copy link
Contributor

One thing, we can't use mixed case file names - because the people at mICROsOFT decided to ignore case, which cause problems. I recommend this convention for all open source projects. I can work with it as is, and my just make the changes and commit them if you are on vacation. (Have a good vacation).

@ddfridley
Copy link
Contributor

I realize some of them were already mixed case - but I have been burned by this recently. I'll fix it.

@ice1080
Copy link
Contributor Author

ice1080 commented Oct 21, 2022

Sorry, which files are incorrect? I can fix them today. Unfortunately macOS also ignores case, and it's really only linux that is fully case sensitive with files.

@ddfridley
Copy link
Contributor

several in app/components/auth-form/ - resetPassword is the new one, but might as well fix the others too.

Storybook is interesting, when I run it, it has something that complains about case. But even git (on windows anyway) doesn't track the difference between Footer.js and footer.js

Also, if you do a new commit, run npm install first so that the new version number in package.json gets updated in package-lock.json

@ice1080
Copy link
Contributor Author

ice1080 commented Oct 21, 2022

Sounds good. Are you fixing them or am I?
And sorry about that, I thought I had included the updated package-lock.json, but that must have only been in civil-server.

@ddfridley ddfridley merged commit 0390b33 into EnCiv:main Oct 21, 2022
@ice1080 ice1080 deleted the undebate-ssp-send-password#154 branch October 21, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants