undebate-ssp send password#154 #33
Conversation
…p-send-password#154
|
After a quick look: There are some new files in app/tools that I think should be in app/lib. app/tools if for things that you would run from a command line. There is no app/lib in civil-server, yet, but there is in other repos. Also, since send-in-blue-transactional has been moved into civil-server, can it be added to app/index.js so that we can (eventually) import it on the undebate-ssp side. Is there anything else that should go there? I'll figure out how to load and test it tomorrow. |
|
@ddfridley Do you care if we are exporting the individual functions or would you prefer sib to be a class with all the functions on it? |
|
I tested out the export of the sib stuff into undebate-ssp, but the main problem seems to be that SibGetTemplateId assumes that the email templates are local, which means that templates like moderator-invitation.html and candidate-invitation.html aren't being found. This could probably be refactored at some point, but I would say this is becoming a bit of scope creep at this point. For now the functions will continue to be exports in index.js, but it will require some refactoring on both sides to be able to use those. Finishing up one more thing on civil-server now. |
|
Alright that's pushed. At this point all three PR's should again be ready for test and/or merge. Let me know if you find anything else you'd like for these! |
|
Fair conclusion.
Get BlueMail for Android
…On Oct 20, 2022, 5:45 PM, at 5:45 PM, ice1080 ***@***.***> wrote:
I tested out the export of the sib stuff into undebate-ssp, but the
main problem seems to be that SibGetTemplateId assumes that the email
templates are local, which means that templates like
moderator-invitation.html and candidate-invitation.html aren't being
found. This could probably be refactored at some point, but I would say
this is becoming a bit of scope creep at this point. For now the
functions will continue to be exports in index.js, but it will require
some refactoring on both sides to be able to use those. Finishing up
one more thing on civil-server now.
--
Reply to this email directly or view it on GitHub:
#33 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
|
I'm checking this in without being able to run the cypress tests. On PC, this problem prevents cy.exec() from working: cypress-io/cypress#789 and on my MacBook Air, when I run cypress a blank electron window pops up, and nothing happens or can be done. I've tried upgrading to cypress 10 but still had that problem. Will battle more with cypress another time. |
|
In case it makes you feel any better, I just switched to main, pulled the latest, and saw all the cypress tests passing. |
|
Yup that makes me feel better.
Get BlueMail for Android
…On Oct 24, 2022, 2:41 PM, at 2:41 PM, ice1080 ***@***.***> wrote:
In case it makes you feel any better, I just switched to master, pulled
the latest, and saw all the cypress tests passing.
--
Reply to this email directly or view it on GitHub:
#33 (comment)
You are receiving this because you modified the open/close state.
Message ID: ***@***.***>
|
No description provided.