Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD token when readJson from remote #27

Merged
merged 7 commits into from
Oct 8, 2020

Conversation

AlexRex
Copy link
Contributor

@AlexRex AlexRex commented Oct 7, 2020

As stated in the issue: #8 (comment).

It will be nice to be able to use the ::before tag when using private repos. Therefore, this PR.

@AlexRex AlexRex marked this pull request as draft October 7, 2020 14:02
@AlexRex AlexRex marked this pull request as ready for review October 7, 2020 14:17
Copy link
Owner

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for the PR!
It's not working for me though, are you sure that's the correct authentication header? Check out the comment I left and let me know if that works ;)

src/main.ts Outdated Show resolved Hide resolved
@EndBug EndBug added the type: feature New feature or feature request label Oct 7, 2020
@AlexRex
Copy link
Contributor Author

AlexRex commented Oct 8, 2020

Hi, thank you for the PR!
It's not working for me though, are you sure that's the correct authentication header? Check out the comment I left and let me know if that works ;)

That's strange! It is actually working for me with Bearer, but you're right, the docs says token instead. I guess both work, but better to keep the one documented officially.

Co-authored-by: Federico Grandi <fgrandi30@gmail.com>
@AlexRex AlexRex requested a review from EndBug October 8, 2020 07:18
Copy link
Owner

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I found out what the problem was: I was testing the action using the branch on your fork, but that didn't have an updated build, and so wasn't running your changes 😅
After committing the build it worked just right. Maybe it would have worked the original way too, with Bearer, but at this point we'll keep token
I'll add it in the next minor version ;)

@EndBug
Copy link
Owner

EndBug commented Oct 8, 2020

@all-contributors add @AlexRex for code

@allcontributors
Copy link
Contributor

@EndBug

I've put up a pull request to add @AlexRex! 🎉

@AlexRex
Copy link
Contributor Author

AlexRex commented Oct 8, 2020

@EndBug Argh! I thought about it actually, but as the contribution guidelines stated to don't push the built code 😅 .

Thanks for the changes :)

@EndBug
Copy link
Owner

EndBug commented Oct 8, 2020

My bad then 😅
I'll add a git hook to enforce the build on every commit

@EndBug EndBug merged commit a9162ce into EndBug:master Oct 8, 2020
@EndBug
Copy link
Owner

EndBug commented Oct 8, 2020

Published in v1.6.0 (v1, latest) 🎉
Thanks again for the PR :)

@AlexRex AlexRex deleted the add-token-when-getting-before-version branch October 9, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants