-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD token when readJson from remote #27
ADD token when readJson from remote #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for the PR!
It's not working for me though, are you sure that's the correct authentication header? Check out the comment I left and let me know if that works ;)
That's strange! It is actually working for me with |
Co-authored-by: Federico Grandi <fgrandi30@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I found out what the problem was: I was testing the action using the branch on your fork, but that didn't have an updated build, and so wasn't running your changes 😅
After committing the build it worked just right. Maybe it would have worked the original way too, with Bearer
, but at this point we'll keep token
I'll add it in the next minor version ;)
@all-contributors add @AlexRex for code |
I've put up a pull request to add @AlexRex! 🎉 |
@EndBug Argh! I thought about it actually, but as the contribution guidelines stated to don't push the built code 😅 . Thanks for the changes :) |
My bad then 😅 |
Published in |
As stated in the issue: #8 (comment).
It will be nice to be able to use the
::before
tag when using private repos. Therefore, this PR.