New command_from_element_iter constructor functions for DICOM objects #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enet4
force-pushed
the
imp/object/command_from_iter
branch
from
918be6b
to
a7e3776
Compare
- methods which add Command Group Length automatically
Enet4
force-pushed
the
imp/object/command_from_iter
branch
from
a7e3776
to
3d4120e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new functions for construction DICOM objects which represent command sets. The main perk of
InMemDicomObject::command_from_element_iterover justInMemDicomObject::from_element_iteris that a Command Group Length (0000, 0000) is automatically calculated and added to the output object.This also updates
echoscu,storescu,findscuandstorescpto use this function, making them a bit leaner.