[Fix] BOT generation for encapsulated data #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enet4
reviewed
Jul 28, 2023
Co-authored-by: Eduardo Pinho <enet4mikeenet@gmail.com>
|
The issue was kind of tricky to spot, the generated files could be open with Weasis, Aliza, etc. DCMTK did not show any issues nor GDCM. It was cornerstone dicom-parser which failed due to this issue. |
That is interesting. Indeed, any parser relying uniquely on the basic offset table to identify the number of frames of an image could choke on this. In any case, thank you very much @dougyau. I will try to push a patch release soon. |
Enet4
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BOT of the pixel data should point to the beginning of each frame. The original implementation was adding 1 extra index which was wrong as the last entry pointed to the end of the file.