Make openjp2 opt-in #449
Merged
Make openjp2 opt-in #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove openjp2 as a default Cargo feature - remove Windows-specific Cargo features, since the default now works - tweak CI workflow accordingly
Enet4
added
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openjpeg-sysprovides a good implementation, but requires linking with non-Rust code.openjp2is written in Rust, but only works in some platforms due to the nature of the code port. Neither of which is ready to be a default implementation.This PR resolves #446 by requiring consumers to pick a JPEG 2000 implementation.
Summary
openjp2as a default Cargo feature