Migrate rules_scala to bzlmod, delete WORKSPACE #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new comments in MODULE.bazel and the comments included in the rules_scala patch contain all the details behind this change.
jayconrod
approved these changes
May 20, 2024
mbland
added a commit
that referenced
this pull request
Jul 9, 2024
Also removes extra whitespace and blank lines from README.md. I inadvertently broke Swift builds and tests in #317 because I added a `bazel_dep()` for `rules_cc` _before_ the one for `apple_support`. This restores the proper order. FWIW, building or testing `//swift:tests` remotely still doesn't seem to work. It hangs on `--config=remote_macos_x64`, and fails on `--config=remote_linux_x64` with: ```txt ERROR: .../external/rules_swift~~non_module_deps~build_bazel_rules_swift_local_config/BUILD:9:22: in xcode_swift_toolchain rule @@rules_swift~~non_module_deps~build_bazel_rules_swift_local_config//:toolchain: Traceback (most recent call last): File ".../external/rules_swift~/swift/internal/xcode_swift_toolchain.bzl", line 641, column 21, in _xcode_swift_toolchain_impl env = _xcode_env(target_triple = target_triple, xcode_config = xcode_config) File ".../external/rules_swift~/swift/internal/xcode_swift_toolchain.bzl", line 539, column 34, in _xcode_env _bazel_apple_platform(target_triple), File ".../external/rules_swift~/swift/internal/xcode_swift_toolchain.bzl", line 101, column 34, in _bazel_apple_platform return _TRIPLE_OS_TO_PLATFORM[( Error: key ("linux", "gnu") not found in dictionary ERROR: .../external/rules_swift~~non_module_deps~build_bazel_rules_swift_local_config/BUILD:9:22: Analysis of target '@@rules_swift~~non_module_deps~build_bazel_rules_swift_local_config//:toolchain' failed ```
mbland
added a commit
that referenced
this pull request
Jul 9, 2024
Also removes extra whitespace and blank lines from README.md. I inadvertently broke Swift builds and tests in #317 because I added a `bazel_dep()` for `rules_cc` _before_ the one for `apple_support`. This restores the proper order. FWIW, building or testing `//swift:tests` remotely still doesn't seem to work. It hangs on `--config=remote_macos_x64`, and fails on `--config=remote_linux_x64` with: ```txt ERROR: .../external/rules_swift~~non_module_deps~build_bazel_rules_swift_local_config/BUILD:9:22: in xcode_swift_toolchain rule @@rules_swift~~non_module_deps~build_bazel_rules_swift_local_config//:toolchain: Traceback (most recent call last): File ".../external/rules_swift~/swift/internal/xcode_swift_toolchain.bzl", line 641, column 21, in _xcode_swift_toolchain_impl env = _xcode_env(target_triple = target_triple, xcode_config = xcode_config) File ".../external/rules_swift~/swift/internal/xcode_swift_toolchain.bzl", line 539, column 34, in _xcode_env _bazel_apple_platform(target_triple), File ".../external/rules_swift~/swift/internal/xcode_swift_toolchain.bzl", line 101, column 34, in _bazel_apple_platform return _TRIPLE_OS_TO_PLATFORM[( Error: key ("linux", "gnu") not found in dictionary ERROR: .../external/rules_swift~~non_module_deps~build_bazel_rules_swift_local_config/BUILD:9:22: Analysis of target '@@rules_swift~~non_module_deps~build_bazel_rules_swift_local_config//:toolchain' failed ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new comments in MODULE.bazel and the comments included in the rules_scala patch contain all the details behind this change.