Enable different Scala versions #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates //scala/extensions:config.bzl to provide a proper module
API that allows the user to configure different Scala versions.
For now, 2.13.12 is the latest Scala 2 version supported by rules_scala
(v6.6.0), defined in //third_party/repositories:scala_2_13.bzl. Setting
it to a later version results in an error:
```txt
File "@io_bazel_rules_scala//third_party/repositories/repositories.bzl",
line 86, column 17, in repositories
fail(version_message % (scala_version, repository_scala_version))
Error in fail:
Scala config (2.13.14) version does not match repository version (2.13.12)
```
Signed-off-by: Mike Bland <mbland@engflow.com>
mbland
requested review from
jayconrod,
benjaminp,
TheGrizzlyDev and
BillyAutrey
benjaminp
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates //scala/extensions:config.bzl to provide a proper module API that allows the user to configure different Scala versions.
For now, 2.13.12 is the latest Scala 2 version supported by rules_scala (v6.6.0), defined in //third_party/repositories:scala_2_13.bzl. Setting it to a later version results in an error:
File "@io_bazel_rules_scala//third_party/repositories/repositories.bzl", line 86, column 17, in repositories fail(version_message % (scala_version, repository_scala_version)) Error in fail: Scala config (2.13.14) version does not match repository version (2.13.12)