Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDS code change testing #1067

Merged

Conversation

likhitha-surapaneni
Copy link
Contributor

Ticket: ENSVAR-6078

@likhitha-surapaneni likhitha-surapaneni marked this pull request as draft January 30, 2024 09:40
@nuno-agostinho nuno-agostinho self-assigned this Feb 12, 2024
@likhitha-surapaneni likhitha-surapaneni marked this pull request as ready for review March 26, 2024 16:52
Copy link
Contributor

@nuno-agostinho nuno-agostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes, @likhitha-surapaneni!

When running VEP on ClinVar data with/without this PR changes, the only differences relate to incomplete transcripts (see ENSVAR-6078), a problem that is outside the scope of this PR.

I just have a smaller comment before approving.

modules/Bio/EnsEMBL/Variation/TranscriptVariationAllele.pm Outdated Show resolved Hide resolved
@likhitha-surapaneni likhitha-surapaneni changed the base branch from postreleasefix/112 to postreleasefix/113 April 19, 2024 14:57
Copy link
Contributor

@nuno-agostinho nuno-agostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @likhitha-surapaneni!

@nuno-agostinho nuno-agostinho merged commit 87e0067 into Ensembl:postreleasefix/113 May 9, 2024
1 check passed
@nuno-agostinho
Copy link
Contributor

Merged into main and release/113 branches.

nuno-agostinho added a commit to nakib103/ensembl-vep that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants