Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appris method on Transcript #382

Merged
merged 3 commits into from
May 8, 2019
Merged

appris method on Transcript #382

merged 3 commits into from
May 8, 2019

Conversation

tgrego
Copy link
Contributor

@tgrego tgrego commented Apr 29, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing

Description

See ENSCORESW-2915

There are 3 main available Transcript tags (TSL, GENCODE Basic and APPRIS)
https://www.ensembl.org/info/genome/genebuild/transcript_quality_tags.html
On a Transcript object, the first 2 can be fetched with the tsl() and gencode_basic() methods, but there is no equivalent method to retrieve the appris tags.

This adds the missing appris() to Transcript. It returns the tag string (if available) or undef. This is the same behaviour as in tsl().

Use case

Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place.

Benefits

Easy access to appris tags.

Possible Drawbacks

none I can see

Testing

Have you added/modified unit tests to test the changes?
yes

If so, do the tests pass/fail?
pass

Have you run the entire test suite and no regression was detected?
yes

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 81.464% when pulling b0b32e7 on appris into 6699433 on master.

@tgrego tgrego requested review from mira13 and s-mm May 3, 2019 15:00
@mkszuba mkszuba requested review from mkszuba and removed request for s-mm May 8, 2019 12:13
my $self = shift;
my @attributes = @{ $self->get_all_Attributes('appris') };
my $appris;
$appris = $attributes[0]->value if scalar(@attributes) > 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for future readers: accepting this occurrence of postfix notation for consistency with gencode_basic() and tsl().

@mkszuba mkszuba merged commit cb7c8c6 into master May 8, 2019
@mkszuba mkszuba deleted the appris branch May 8, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants