Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema_patcher.pl: Update location of ontology schema #401

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

mkszuba
Copy link
Contributor

@mkszuba mkszuba commented Jul 18, 2019

Description

Have the schema patcher look for ontology patches in ensembl-ontology-schema rather than ols-ensembl-loader.

Use case

During a recent discussion regarding the patching of test databases in ensembl-rest it has been decided to hand the ontology schema from Production back to Infrastructure because said schema is much more closely tied with Core code than with OLS.

Benefits

ensembl-rest branch creation will be more straightforward because there will be one PR less to wait for and process.

Possible Drawbacks

It will be up to Infra again to update ontology schema version every release.

Testing

Have you added/modified unit tests to test the changes?

No.

If so, do the tests pass/fail?

N/A

Have you run the entire test suite and no regression was detected?

Yes, no regression detected. Moreover, patching test databases for version 99 using the updated script correctly retrieves and applies patch_98_99_a.sql from the new repository.

Copy link
Contributor

@ens-bwalts ens-bwalts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, a good opportunity to clean up the whitespace.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.467% when pulling 2d7a9e8 on ontology_schema_repository into b6ff4fc on master.

@ens-bwalts ens-bwalts requested a review from tgrego July 18, 2019 16:12
Copy link
Contributor

@tgrego tgrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@mkszuba mkszuba merged commit 7122d47 into master Jul 19, 2019
@mkszuba mkszuba deleted the ontology_schema_repository branch July 19, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants