Enscoresw 3267

[ameya1981]

Requirements

• Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
• Review the contributing guidelines for this repository; remember in particular:
  • do not modify code without testing for regression
  • provide simple unit tests to test the changes
  • if you change the schema you must patch the test databases as well, see Updating the schema
  • the PR must not fail unit testing

Description

Make 'type' column in core.external_db table to NOT NULL

Use case

As requested in ENSINT-307
Healtchecks were checking for Not Null, but table was allowing null values.

Benefits

The health-check can be deprecated

Possible Drawbacks

Value needs to be entered even if not applicable

Testing

No unit tests changed

If so, do the tests pass/fail?
N/A

Have you run the entire test suite and no regression was detected?
No regression detected

[mkszuba]

In addition to the Variation schema not being up to date, I am afraid the description of your second commit is not accurate - it changes more than table.sql and applies more than this one patch. Could you change it to something along the lines of "patched test databases"?

[coveralls]

Coverage decreased (-0.02%) to 81.459% when pulling a8a76c4 on ENSCORESW-3267 into 940e1fb on master.

[mkszuba]

I am afraid the description of your second commit is not accurate - it changes more than table.sql and applies more than this one patch. Could you change it to something along the lines of "patched test databases"?

[mkszuba]

Alas, that last change has simply been a new empty commit instead of an amendment to the previous one. I'll just squash these into one for you this time.