Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yearly copyright update #464

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Yearly copyright update #464

merged 2 commits into from
Jan 17, 2020

Conversation

tgrego
Copy link
Contributor

@tgrego tgrego commented Jan 2, 2020

This brings the copyright notices to the year 2020.

@coveralls
Copy link

coveralls commented Jan 2, 2020

Coverage Status

Coverage remained the same at 81.426% when pulling b3596d0 on copyright_2020 into 491b3b9 on master.

Copy link
Contributor

@ens-bwalts ens-bwalts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[bwalts@noah-login-02 ensembl (copyright_2020)]$ git diff HEAD^ | grep ^+ | grep -v +++ | wc -l
914
[bwalts@noah-login-02 ensembl (copyright_2020)]$ git diff HEAD^ | grep ^+ | grep -v +++ | fgrep  'Copyright [2016-2020] EMBL-European Bioinformatics Institute' | wc -l
911
[bwalts@noah-login-02 ensembl (copyright_2020)]$ git diff HEAD^ | grep ^+ | grep -v +++ | fgrep  'Copyright [2018-2020] EMBL-European Bioinformatics Institute' | wc -l
3

911+3=914, so the only lines changed are the copyright.

Likewise:

[bwalts@noah-login-02 ensembl (copyright_2020)]$ fgrep -ir copyright * | fgrep -v Wellcome | wc -l
938
[bwalts@noah-login-02 ensembl (copyright_2020)]$ fgrep -ir copyright * | fgrep -v Wellcome | fgrep -v 2020 | wc -l
24

938-24=914
24 lines with the word "copyright" in them checked, and determined not the copyright notice to be updated.

So, it looks like the annual copyright updater ran correctly. However, there are a few files that perhaps should have a copyright notice but don't.
fgrep -Lir copyright *
lists 440 files without the word copyright in them. Most of those probably don't need one, but there are a few to be considered:

  • misc-scripts/canonical_transcripts/reason_changes.pl
  • misc-scripts/xref_mapping/XrefMapper/gallus_gallus.pm
  • misc-scripts/xref_mapping/XrefParser/CGNCParser.pm
  • misc-scripts/xref_mapping/store_ccds_xrefs.pl

Need to decide if these (or others) should be taken care of here or in a separate PR. Happy to approve if we decide that new copyright notices should be handled separately.

@tgrego tgrego requested a review from ameya1981 January 17, 2020 12:53
Copy link

@ameya1981 ameya1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the copyright changes. More files covered.

@tgrego tgrego merged commit adfe212 into master Jan 17, 2020
@magaliruffier magaliruffier deleted the copyright_2020 branch June 10, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants