Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable VGNC xrefs for 15 more species #471

Merged
merged 3 commits into from
Jan 27, 2020

Conversation

mkszuba
Copy link
Contributor

@mkszuba mkszuba commented Jan 24, 2020

Description

xref_config.ini: enable VGNC xrefs for pig (full gene set) and 14 more new species (cytochrome P450 only)

Use case

As requested by VGNC.

Benefits

More species with VGNC xrefs.

Possible Drawbacks

Increased run time of the xref pipeline. Species from commit 3eb69e9 may or may not prove problematic.

Testing

Have you added/modified unit tests to test the changes?

No.

If so, do the tests pass/fail?

N/A

Have you run the entire test suite and no regression was detected?

No, there aren't any xref-pipeline tests in the test suite.

Marek Szuba added 3 commits January 24, 2020 17:14
aotus_nancymaae	37293
carlito_syrichta	1868482
cercocebus_atys	9531
chlorocebus_sabaeus	60711
macaca_fascicularis	9541
macaca_nemestrina	9545
mandrillus_leucophaeus	9568
nomascus_leucogenys	61853
otolemur_garnettii	30611
pan_paniscus	9597
propithecus_coquereli	379532
rhinopithecus_bieti	61621
cebus_capucinus_imitator	1737458
saimiri_boliviensis_boliviensis	39432

Committing these two separately from the other 12 on the off chance
three-part names could cause problems - especially in case of Capuchin,
which appears as 'Cebus capucinus imitator' on the Ensembl species list
but whose database prefix is simply 'cebus_capucinus'.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.419% when pulling 3eb69e9 on feature/vgnc_xrefs_new_species into adfe212 on master.

Copy link

@ameya1981 ameya1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the additional vgnc species. No separate parsers required. So existing parsers, mapper should work.

Copy link
Contributor

@ens-bwalts ens-bwalts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL resolves and tax IDs match species

@ens-bwalts ens-bwalts merged commit 126b7ca into master Jan 27, 2020
@ens-bwalts ens-bwalts deleted the feature/vgnc_xrefs_new_species branch January 27, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants