Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in tests for GENCODE primary transcript attributes #695

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Add in tests for GENCODE primary transcript attributes #695

merged 4 commits into from
Apr 4, 2024

Conversation

nwillhoft
Copy link
Contributor

@nwillhoft nwillhoft commented Apr 3, 2024 •
edited by sgiorgetti
Loading

Testing to make sure the transcript attribute 'GENCODE primary' is correctly accessed via the API.

Relates to recent PRs in:

@nwillhoft nwillhoft self-assigned this Apr 3, 2024
@nwillhoft
Copy link
Contributor Author

Have added the new gencode_primary attribute to test files (attribute_type.txt, transcript_attrib.txt) but it's not yet being associated with the transcript via the API.

sgiorgetti
sgiorgetti requested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@sgiorgetti sgiorgetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per specific comments on the changes

modules/t/test-genome-DBs/homo_sapiens/core/transcript_attrib.txt Outdated Show resolved Hide resolved
modules/t/test-genome-DBs/homo_sapiens/core/attrib_type.txt Outdated Show resolved Hide resolved
modules/t/transcript.t Outdated Show resolved Hide resolved
@nwillhoft nwillhoft marked this pull request as ready for review April 4, 2024 08:54
sgiorgetti
sgiorgetti approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@sgiorgetti sgiorgetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me :-)
Thanks

@sgiorgetti sgiorgetti merged commit a692505 into main Apr 4, 2024
2 checks passed
@sgiorgetti sgiorgetti deleted the feature/gprimary_tests branch April 4, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiorgetti sgiorgetti sgiorgetti approved these changes

Assignees

@nwillhoft nwillhoft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwillhoft @sgiorgetti