Stack Overflow when querying after version 4.0.1

[ifilgud]

Hi!
I'm using the lib for creating the api using the automatic schema creation based on a Db Context.
It works perfectly with version 4.0.1 of nuget package, but anything superior will crash the exe on any query.

The stack trace is huge and its not giving me any clue, but I'm attaching it just in case.
You will see traces for Elsa Workflows, because I use it on the same program, everything registered as services in the ASP.NET startup.

Log.txt

[bzbetty]

ah interesting, that's the new json serialiser added to solve issues with inheritance. Guessing you don't use GQL interfaces or union types currently? you could potentially default back to the old serializer.

[ifilgud]

Hi, yes, my classes are quite normal. Entities with string, int, bool properties and some lists of other entities, and I'm not using any special interface nor union types (I don't know what are they for :D), but list items have navigation properties (for Entity Framework) that points to the parent again, so it seems that the parser is entering in an endless loop analysing those classes. I'm already using JsonIgnore and GraphQlLIgnoreAttribute to skip them, so is there any other attribute apart from them to ignore the navigation properties?

If not, how to use the old serializer?

Thanks!

[lukemurray]

@bzbetty is this the RuntimeTypeJsonConverter ?

[bzbetty]

@lukemurray yeah I think so

[lukemurray]

@ifilgud are you able to set an example up that reproduces it? Maybe look at modifying the demo project in the repo? I have yet to reproduce this.

[ifilgud]

Yes, I can try with the demo project, but is there a place where you can download it directly? Or do I have to create a new one manually and copy the example code from the doc?

I think the problem might be because I have this kind of relationships in the classes:

class MainItem
{
    Guid Id {get;set;}
    List<OtherItem> Items {get;set;}
}

class OtherItem
{
    Guid Id {get;set;}

    [JsonIgnore]
    [GraphQLIgnore]
    MainItem ParentItem {get;set;} // Navigation property for entity framework
}

[lukemurray]

The Demo project has similar relationships.

You can git clone this repo, open it in VS Code and run the Demo project.

[ifilgud]

Hi, I haven't been able to reproduce with the demo project, so I'm attaching a clean version of the real code, removing business logic and references to the company so you can test. It contains the real domain classes and Elsa Workflows included, because maybe the problem is related to it.
Example.zip
Thanks in advance!

[bzbetty]

@ifilgud are there steps to repro the issue on the example project? eg does it happen for particular queries?

[ifilgud]

It happens querying for the schema or for a normal query

[ifilgud]

This query should work and it crashes:

query {
  incidents(filter: "", sort: [
    {
      incidentCreationTime: DESC
    }], skip: 0, take: 10) {
    items {
      incidentId
      incidentName
      proposedActionList {
        id
        action {
          actionId
          timeStamp
          actionType
          affectedDevice
          actionStatus
          actionCreationTime
          actionLastChangeTime
          actionExecutionTime
          actionTimeout
          executedBy
          executedByMachine
          targetSystem
          actionAdditionalInfo
        }
        order
      }
      incidentCreationTime
      incidentLastChangeTime
      incidentLocationCoordinates
      incidentStatus
      fakeIncident
      eventsRelatedList {
        eventName
        eventId
        externalEventId
        eventType
        eventLocation {
          name
          coordinatesGPS
          itemType
        }
        eventTimeStamp
        eventAffectedDevice {
          name
          coordinatesGPS
          itemType
        }
        incidentRelatedId
        applicationName
        userName
        fullComputerName
        eventInfo
      }
      incidentSeverity
      incidentExtent
      incidentMaximumLifeTime
      incidentType
      occurrencesNumber
      additionalInfo
      log {
        incidentId
        logType
        userName
        computerName
        timestamp
        additionalInfo
      }
    }
    hasPreviousPage
    hasNextPage
    totalItems
  }
}

[bzbetty]

Right, can confirm it's the new serialiser.

Unsure if it's due to a loop in what's being serialised or if it's failing to fall back to the default serialiser when it doesn't know how to handle part of the object.

Should be easy enough to debug, just didn't have time yet.

[bzbetty]

actually this one seems to be a bit odd, it gets in an infinite loop when serializing a boolean value but I can't replicate it with a test.

I do note the JsonSerializerOptions do seem a bit different - for example your one has a property called "IsImmutable" but the one in the tests doesn't appear to. Could be different version of .NET? (both 6, so somehow a sub version?) or potentially either Elsa (or another library) somehow changes serialization?

[ifilgud]

I don't know how can I help you. That property IsImmutable is not being changed manually as I can see.
Its possible that Elsa Workflows changes somehow the serialization in a way that was not affecting previously. Try removing it from the Program.cs and removing the packages also to check if its related. Maybe creating a new project but using my DbContext to be sure, because I tried to disable Elsa but it was still somehow added to ASP.NET services and couldn't test it properly.

Maybe forcing the serialization config en EntityGraphQl can avoid the problem, not sure

[bzbetty]

Not related to Elsa.

Doesn't seem to happen if I remove the [UseOffsetPaging] attribute which is curious.