-
Notifications
You must be signed in to change notification settings - Fork 63
support default values in c# methods #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Think this is failing due to another merge. Gets the same Reuse slot error (which seem familiar to me, something about trying to add an Expression type or potentially Task<> to a graphql type. eg
|
Can we add a test/check that the schema/introspection is generating the default values too? |
added in tests/code for sdl/introspection default values |
added a couple more SDL default values checks which requires some form of serialisation, used a json serialiser but it's not quite right, so need another method. eg
seems to work for enums, integers, booleans, and empty arrays though. Are you aware of a serializer more suitable? |
01bf1b8
to
30e9ccb
Compare
30e9ccb
to
320add1
Compare
My most hated test too :P Need to look at changing it some how.. Thanks though |
believe this makes default values in mutaitons work
eg