feat: use scoped settings for global configurable options #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const GATHER_GETINDEX_DISABLED = Ref(false) | ||
| const DEBUG_MODE = ScopedSetting(false) | ||
| const LARGE_CONSTANT_THRESHOLD = ScopedSetting( | ||
| GetPreference(Reactant, "large_constant_threshold", 100 << 20) # 100 MiB |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| GetPreference(Reactant, "large_constant_threshold", 100 << 20) # 100 MiB | |
| GetPreference(Reactant, "large_constant_threshold", 100 << 20), # 100 MiB |
wsmoses
reviewed
Sep 2, 2025
| const DEBUG_ALIASED_BUFFER_ASSIGNMENT_ERROR = ScopedSetting( | ||
| GetPreference(Reactant, "debug_aliased_buffer_assignment_error", false) | ||
| ) | ||
| const DEBUG_KERNEL = ScopedSetting(GetPreference(Reactant, "debug_kernel", false)) |
There was a problem hiding this comment.
these compile time attributes really don't make sense to be scoped, since they're set once per the entire compilation
There was a problem hiding this comment.
I just searched through and replaced them 😓. will go through all of them once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScopedValueandRefwithScopedSettingwith_configfixes #1608