Dataset upload ui updates #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dropdowns for each feature to select its type. Code working for categorical types. Code working mostly for ordinal types. Need UI for setting ordinal order and UI visual changes overall.
Commit before adding react-sortable-hoc package
Commit before additional changes
both - text input box blocks other input for better handling of changes made via them categorical - add parsing of ranges in text input orginal - store previous ranking and restore it if user changes to other type and then back to ordinal
For features auto-detected as type categorical, don't show dropdown option to make them numeric, and make sure they're always categorical even if user omits them from the user text input for specifying cat features. Change determination of feature default type to happen only once when new dataset is loaded - for efficiency.
Add new feature type to track which column has been designated as the dep. column. Prevent it from being overwritten by the 'set all types' option and by the user text boxes.
Also use same new CSS style for tables in dataset view pages to freeze first row.
Add feature name, feature type dropdown and rank button to header cell
Not sure what happened
Also remove some unused css classes in App.css
Saved it in a different branch to revisit in the future.
Small issue remains with the item as it's clicked and dragged - text moves down slightly within the outline
Clean up help text for Categorical Features button. Remove barchart icon
weixuanfu
suggested changes
Nov 19, 2020
There was a problem hiding this comment.
- on the ordinal/categorical feature inputs, the texts are too close to left side of the pop-up windows. I think need 2-4 blank spaces in each line.
- Suggestion: Using "Set Ordinal" and "Set Categorical" on the bottons on the screenshot below.
- Please rebase the branch to master branch for passing CI builds.
|
I've addressed @weixuanfu items 1 & 2 from #298 (review) |
|
Hmm, I am not sure why CI builds failed. I will check it tomorrow.
|
|
Hmm Could you please check and fix those failed tests for uploading dataset in CI builds? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hmm, I thought I made a pull request for this last week.
In any case, I ran various manual functionality tests again, and made some cosmetic changes, including adding row numbers.