Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break export() into sub-parts #66

Merged
merged 5 commits into from
Dec 26, 2015
Merged

Conversation

pronojitsaha
Copy link
Contributor

Implements the final part of #44 i.e. 'Replace the function calls with their corresponding Python code'

@rhiever
Copy link
Contributor

rhiever commented Dec 24, 2015

It looks like the build for Python 3 is failing. Maybe something to do with the new module?

Also, perhaps we should rename tpot_export.py to export_utils.py and move all of the export-related functions there (except for export(), of course).

@pronojitsaha
Copy link
Contributor Author

Yes I saw that too, the error is in importing the new module. ERROR: Failure: ImportError (No module named 'tpot_export'). In my local machine it runs perfectly. Can you run the build once again and check?

Else will check this over the weekend. Renaming to export_utils.py is a good idea. 👍 Will implement that too.

And lastly but most importantly, Merry Christmas 🎄 to you and also to @rasbt and everyone else!

@rhiever
Copy link
Contributor

rhiever commented Dec 25, 2015

I think you need to change:

from tpot_export import ...

to

from .tpot_export import ...

to clarify that it's a local import.

Merry Christmas all! 🎅

from export_utils import *
TO
from .export_utils import *
@pronojitsaha
Copy link
Contributor Author

@rhiever Thanks for the tip! I think this looks good now. Let me know.

rhiever pushed a commit that referenced this pull request Dec 26, 2015
Break export() into sub-parts
@rhiever rhiever merged commit 5bfffcd into EpistasisLab:master Dec 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants