Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluation-improvement #926

Merged
merged 1 commit into from
Oct 14, 2019
Merged

evaluation-improvement #926

merged 1 commit into from
Oct 14, 2019

Conversation

zhouker94
Copy link
Contributor

@zhouker94 zhouker94 commented Oct 7, 2019

[please review the Contribution Guidelines prior to submitting your pull request. go ahead and delete this line if you've already reviewed said guidelines.]

What does this PR do?

Evaluation improvement:
use np.unique instead of converting classes to set and list

Where should the reviewer start?

How should this PR be tested?

Any background context you want to provide?

What are the relevant issues?

[you can link directly to issues by entering # then the number of the issue, for example, #3 links to issue 3]

Screenshots (if appropriate)

Questions:

  • Do the docs need to be updated?
    No
  • Does this PR add new (Python) dependencies?
    No

@zhouker94 zhouker94 changed the title use np.unique instead of convert to set and list evaluation-improvement Oct 7, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 95.833% when pulling 9229681 on OwenZhu:evaluation-improvement into 1fcea93 on EpistasisLab:development.

@weixuanfu
Copy link
Contributor

weixuanfu commented Oct 14, 2019

Thank you for the improvement.

@weixuanfu weixuanfu merged commit 4be9390 into EpistasisLab:development Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants