Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bug risks and code quality issues #978

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

mohi7solanki
Copy link
Contributor

@mohi7solanki mohi7solanki commented Dec 15, 2019

Changes:

  • Remove unnecessary list comprehension
  • Set value instead of comparison in tpot_tests.py
  • Remove useless print statement
  • Fix C style iteration in _operator_count
  • Add .deepsource.toml file to file to run continuous static analysis on
    the repository with DeepSource

This PR also adds .deepsource.toml configuration file to run static analysis continuously on the repo with DeepSource. Upon enabling DeepSource, quality and security analysis will be run on every PR to detect 500+ types of problems in the changes — including bug risks, anti-patterns, security vulnerabilities, etc.

DeepSource is free to use for open-source projects, and is used by teams at NASA, Uber, Slack among many others, and open-source projects like ThoughtWorks/Gauge, Masonite Framework, etc.

To enable DeepSource analysis after merging this PR, please follow these steps:

  • Sign up on DeepSource with your GitHub account and grant access to this repo.
  • Activate analysis on this repo here.
  • You can also look at the docs for more details. Do let me know if I can be of any help!

Questions:

  • Do the docs need to be updated? - NO
  • Does this PR add new (Python) dependencies? - NO

Changes:
- Remove unnecessary list comprehension
- Set value instead of comparison in `tpot_tests.py`
- Remove useless print statement
- Fix C style iteration in `_operator_count`
- Add .deepsource.toml file to file to run continuous static analysis on
  the repository with DeepSource
@weixuanfu weixuanfu changed the base branch from master to development December 16, 2019 14:01
@weixuanfu
Copy link
Contributor

Thank you for the fixes and suggestion of DeepSource. I will merge this PR to dev branch for now. I checked the DeepSource report from your forked repo, it seems tpot need a lot of code cleaning but some of major code issues may be not valid. We will check the docs of DeepSource and also clean TPOT codes before merging it to master branch.

@weixuanfu weixuanfu merged commit 1cc869f into EpistasisLab:development Dec 16, 2019
@mohi7solanki
Copy link
Contributor Author

@weixuanfu thanks for merging, you can report false positives on the platform if you find any, we will try to fix them right away or ping me at mohit@deepsource.io for any queries/suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants