add get assignment methods with context #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoromanovsky
approved these changes
Jul 7, 2025
Comment on lines
8
to
+15
| type IAssignmentLogger interface { | ||
| LogAssignment(event AssignmentEvent) | ||
| } | ||
|
|
||
| type IAssignmentLoggerContext interface { | ||
| LogAssignment(context.Context, AssignmentEvent) | ||
| } | ||
|
|
There was a problem hiding this comment.
thanks for adding this. would appreciate a comment on IAssignmentLogger declaring it deprecated at next major version.
There was a problem hiding this comment.
added the comment 👍
|
|
||
| switch { | ||
| case ec.loggerContext != nil: | ||
| // prioritise logger context if it's defined in the config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eppo Internal:
🎟️ Fixes issue
📜 Design Doc: link if applicable
Motivation and Context
Add methods that pass context while getting assignment
Description
Context is very useful to pass values (e.g. for tracing in the logger)
How has this been documented?
How has this been tested?