Migrate Javascript SDK to use V2 Randomization Endpoint #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also add "-dto" suffix to dto file names - remove duplicate rules dto file
vpai
commented
Sep 15, 2022
| rm -rf $(testDataDir) | ||
| mkdir -p $(testDataDir) | ||
| gsutil cp gs://sdk-test-data/rac-experiments.json $(testDataDir) | ||
| gsutil cp gs://sdk-test-data/rac-experiments-v2.json $(testDataDir) |
There was a problem hiding this comment.
Uses the new test RAC uploaded to S3.
vpai
commented
Sep 15, 2022
| percentExposure: 1, | ||
| enabled: true, | ||
| subjectShards: 100, | ||
| variations: mockVariations, |
There was a problem hiding this comment.
variations and percentExposure no longer live at the top level, they live on individual allocations.
vpai
commented
Sep 15, 2022
| end: 67, | ||
| const experimentName = 'mock-experiment'; | ||
|
|
||
| const mockExperimentConfig = { |
There was a problem hiding this comment.
Added this to DRY up this file a bit.
also add comments to getAssignment function
vpai
force-pushed
the
varun/rac-v2-updates
branch
from
078b3c1 to
a482d5b
Compare
ploomiz
approved these changes
Sep 15, 2022
- matchesAnyRule -> findMatchingRule - remove redundant rule length check
petzel
approved these changes
Sep 16, 2022
Co-authored-by: Eric Petzel <epetzel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Eppo-exp/eppo#4711
Description
Updated the
getAssignmentlogic to use the allocation (variations + exposure) for the matched targeting rule. The API response inserts a default rule that always matches if the experiment does not have any rules.See the above design doc for details.
Also made some changes to code organization:
-dtoand grouped them in adtofolder.client.How has this been tested?