Add configuration skipInitialPoll to allow the SDK to be configured without any CDN requests. (FF-2047) #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout any CDN requests. (FF-2047)
aarsilv
approved these changes
May 4, 2024
| let startRequestSuccess = false; | ||
| let startAttemptsRemaining = | ||
| 1 + (options?.maxStartRetries ?? DEFAULT_INITIAL_CONFIG_REQUEST_RETRIES); | ||
| let startAttemptsRemaining = options?.skipInitialPoll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ithout any CDN requests. (FF-2047)
labels: mergeable
Fixes: #issue
Motivation and Context
Users of the JS client SDK (browser) have a desire for an off-line mode that can be paired with providing a custom persistence store implementation that which can be bootstrapped by a server process and reduce client-sourced CDN requests to 0. The serving cache will be populated from this persistent store on startup.
JS clients have polling disabled by default but an initial request is still made.
Description
Adds a new configuration parameter
skipInitialPolland implements it in the poller. This paired with previously added support for a custom persistence store allows for an off-line mode that is populated off-process.How has this been tested?
New unit test.