fix(sdk): [EPD-2310] 💀 getBoolAssignment -> 👶 getBooleanAssignment
#72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecsl
requested review from
aarsilv and
schmit
and removed request for
aarsilv
|
Once merged, this will require docs updates to https://github.com/Eppo-exp/js-client-sdk/blob/main/README.md#assign-anywhere |
schmit
reviewed
Jun 5, 2024
schmit
approved these changes
Jun 5, 2024
@schmit should I do that in the same PR or a follow up one? |
|
alright I went ahead and bumped the minor version to make this atomic, PTAL - couldn't find a changelog file though |
|
Yup I usually do it in the same PR |
felipecsl
deleted the
felipecsl/epd-2310-sdk-deprecate-getboolassignment-and-create
branch
|
I'll publish this and then update js-client-sdk next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: EPD-2310
Motivation and Context
The README refers to a
getBooleanAssignmentmethod that doesnt exist.From Slack discussionredacted for privacy reasonsAccording to Semver, this will require a minor version bump since this is a backwards compatible change.
Description
getBoolAssignmentgetBoolAssignmenttogetBooleanAssignmentHow has this been tested?
Ran unit tests