FF-2139 Fix base64 encoding/decoding for React Native 0.72.x #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghuels
force-pushed
the
greg/FF-2139/base64-fix
branch
from
3db16e3 to
d9ea513
Compare
aarsilv
approved these changes
Jun 6, 2024
| "homepage": "https://github.com/Eppo-exp/js-client-sdk-common#readme", | ||
| "devDependencies": { | ||
| "@types/jest": "^29.5.11", | ||
| "@types/js-base64": "^3.3.1", |
| "md5": "^2.3.0", | ||
| "pino": "^8.19.0", | ||
| "semver": "^7.5.4", | ||
| "universal-base64": "^2.1.0" |
greghuels
force-pushed
the
greg/FF-2139/base64-fix
branch
from
d9ea513 to
f330deb
Compare
greghuels
commented
Jun 6, 2024
yarn.lock
Outdated
Comment on lines
788
to
792
| "@types/react-native-base64@^0.2.2": | ||
| version "0.2.2" | ||
| resolved "https://registry.yarnpkg.com/@types/react-native-base64/-/react-native-base64-0.2.2.tgz#d4e1d537e6d547d23d96a1e64627acc13587ae6b" | ||
| integrity sha512-obr+/L9Jaxdr+xCVS/IQcYgreg5xtnui4Wqw/G1acBUtW2CnqVJj6lK6F/5F3+5d2oZEo5xDDLqy8GVn2HbEmw== | ||
|
|
There was a problem hiding this comment.
whoops, I forgot to remove this. I was testing with this library at one point.
leoromanovsky
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes FF-2139
Motivation and Context
Fixes
Property 'atob' doesn't existerror in React Native 0.72.xDescription
atobandbtoaare not built in to React Native's JS runtime for react-native 0.72. Theatobandbtoawere being used by theuniversal-base64package. Replacing this package withjs-base64provides a base64 implementation that doesn't rely on atob, btoa or Buffer existing.How has this been tested?
distdistfiles, along with the newly installedjs-base64module to mynode_modules/@eppo/js-client-sdk-common/distfolder andnode_modules/folders respectivelybtoa('asdf')then decoding the result via the library.Before
After