-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0.3-rc.0 #60
base: main
Are you sure you want to change the base?
v3.0.3-rc.0 #60
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
name: Node.js Setup and Test | ||
on: | ||
workflow_call: | ||
inputs: | ||
node_version: | ||
required: true | ||
type: string | ||
npm_tag: | ||
required: false | ||
type: string | ||
npm_token: | ||
required: true | ||
type: string | ||
|
||
jobs: | ||
setup-and-publish: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-node@v3 | ||
with: | ||
node-version: ${{ inputs.node_version }} | ||
- run: npm install | ||
- run: npm test | ||
- uses: JS-DevTools/npm-publish@v1 | ||
with: | ||
token: ${{ inputs.npm_token }} | ||
access: public | ||
tag: ${{ inputs.npm_tag }} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
name: Publish RC to NPM | ||
on: | ||
workflow_dispatch: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ☝️ and this lets us trigger from UI ✅ |
||
|
||
jobs: | ||
publish: | ||
uses: ./.github/workflows/nodejs-setup.yml | ||
with: | ||
node_version: '18.x' | ||
npm_tag: rc | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. npm tag goes here; end-users need to explicitly select this tag and it won't "accidentally" be treated as a dependency. |
||
npm_token: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor into a shared file so we can be sure the checks are always run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smart!