Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.3-rc.0 #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

v3.0.3-rc.0 #60

wants to merge 2 commits into from

Conversation

leoromanovsky
Copy link
Member

@leoromanovsky leoromanovsky commented May 16, 2024

Fixes: #issue

Motivation and Context

Experimenting with a release process that allows us to have "release candidates" that we can explicitly add to our services and dogfood before publishing for our customers.

Description

Bumping the version programmatically:

➜  node-server-sdk git:(main) yarn version --new-version prerelease --preid rc
yarn version v1.22.22
info Current version: 3.0.2
info New version: 3.0.3-rc.0
✨  Done in 7.75s.

To publish this version:

Caveat: this is different than our normal publish command. There is a new github action in this PR that can be executed manually.

yarn publish --tag rc

For end-users to install:

yarn add @eppo/node-server-sdk@3.0.3-rc.0

How has this been tested?

@@ -0,0 +1,30 @@
name: Node.js Setup and Test
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor into a shared file so we can be sure the checks are always run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart!

uses: ./.github/workflows/nodejs-setup.yml
with:
node_version: '18.x'
npm_tag: rc
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm tag goes here; end-users need to explicitly select this tag and it won't "accidentally" be treated as a dependency.

@leoromanovsky leoromanovsky marked this pull request as ready for review May 16, 2024 22:19
Copy link
Contributor

@aarsilv aarsilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@@ -0,0 +1,30 @@
name: Node.js Setup and Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart!

@@ -0,0 +1,11 @@
name: Publish RC to NPM
on:
workflow_dispatch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ and this lets us trigger from UI ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants